[Enhancement] feat(player): subtitle font size, color & system caption support (#547) - #551
Open
prince-pokharna wants to merge 1 commit into
Open
Conversation
…V21#547) - Add SubtitlePreferences data class with fontSize, textColor, backgroundColor - Add SubtitleStyleManager to read Android TV CaptioningManager system prefs - Add SubtitlePrefsRepository for SharedPreferences persistence - Add SubtitleSettingsFragment with Small/Medium/Large/Extra Large presets - Wire SubtitleStyleManager into player screen - Respects accessibility caption settings per Android TV guidelines Closes ProdigyV21#547
github-actions
Bot
added
the
area: android
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds user-facing subtitle customisation to ARVIO's player, resolving the
accessibility gap identified in #547.
Changes
SubtitlePreferences.kt– data model (fontSize, textColor, backgroundColor, position, fontStyle, useSystemCaptions)SubtitleStyleManager.kt– reads Android TVCaptioningManagersystem caption prefs; falls back to app defaults; appliesCaptionStyleCompat+setFixedTextSizetoSubtitleViewSubtitlePrefsRepository.kt– persists preferences via SharedPreferencesSubtitleSettingsFragment.kt+fragment_subtitle_settings.xml– TV D-pad-navigable settings sheet with preset sizes (Small 14sp / Medium 18sp / Large 22sp / Extra Large 28sp), color options, and a system caption toggleTesting
./gradlew :app:compilePlayDebugKotlin— zero errorsAccessibility compliance
Aligns with Android TV caption accessibility guidelines by honouring
CaptioningManager.getUserStyle().Closes #547